Synchronet Git Commit Log

Modified Files:


src/sbbs3/msgdate.c
diff

Use smb_when() to convert the return value of rfc822date()

This explains why Deon was still seeing time_t encoded time values.

Modified Files:


src/sbbs3/main.cpp
diff

Fix-up node status when node status is in-use, but no socket active

This is a situation we can auto-correct and log a message when we do.

Modified Files:


src/sbbs3/userdat.c
diff

Report a different status for NODE_QUIT than NODE_INUSE

Could be helpful for debugging node status issues at some point

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'issue_846_ddmsgreader' into 'master'

DDMsgReader: When doing an indexed newscan, display the progress percentage
when doing the newscan. Should fix issue #846 (reported by Keyop)

Closes #846

See merge request main/sbbs!484

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When doing an indexed newscan, display the progress percentage
when doing the newscan. Should fix issue #846 (reported by Keyop)

Modified Files:


ctrl/chat.ini
diff

ctrl/file.ini
diff

ctrl/main.ini
diff

ctrl/msgs.ini
diff

ctrl/sbbs.ini
diff

ctrl/xtrn.ini
diff

Load/force-saved the config files in latest SCFG

Adds new keys, removes old ones

Updates formatting/white-space

Modified Files:


src/sbbs3/scfg/scfg.c
diff

When using -f (force save), don't write sbbs.ini contents to xtrn.ini

Bug

Modified Files:


exec/viewimsgs.js
diff

Don't exit(non-zero) from this script

A non-zero exit from str_cmds.js (where this script is loaded) will terminate
the call/session. We don't need to call exit() at all from this script.

This fixes issue #848, thank you for the report

Modified Files:


src/sbbs3/main.cpp
diff

When searching for unused nodes, skip nodes that have sockets in-use

We already know such nodes are in-use, so no need to read their node.dab
record and put extra contention on the node.dab file. Hoepfully this
reduces or eliminates occurrences of the error:
    Node n status is WFC, but the node socket (s) and thread are still in use!
Though I kind of expect occurrences of "NODE STATUS FIXUP" errors to likely
return.

We could in theory just track status of nodes in memory (for those
nodes that this instance of sbbs controls), and not read the node.dab file at
all when checking those nodes' status, but:
- that would prevent out of process control of node status
  e.g. using the node utility to mark a node as offline
- we'd have to protect instance of in-memory node status checking/changing
  with a mutex

Modified Files:


src/sbbs3/getkey.cpp
diff

Fix issue when receiving node messages while using down-arrow at pause prompt

Hitting down-arrow key at a pause prompt normally displaye just one more line
of the display text/file, but if you received a node message/telegram/notice
after hitting down arrow, you'd get a screen full of text instead of just a
single (one more) line, as you wanted.

This looks to be because of the anti-recursive protection implemented in
pause() - when it calls nodesync() after the key press, that displays
node/user messages (if there are any) and if pause is called as a result
(e.g. because the line counter was already set to cause a pause after the
next line of output), it'd do nothing since that would be recursive. The fix
is to simply set the line counter as a result of the down-arrow key press
*after* the call to nodesync(), which might display multiple lines, but I
think that's fine.

Modified Files:


src/xpdev/dirwrap.c
diff

A little style clean-up, reduced copy/paste, no functional changes

Reduce the cognitive dissonance

Modified Files:


src/xpdev/dirwrap.c
diff

Comment out access() call in Windows version of getfilecase()

I'm hoping this might help resolve instances where fexistcase() says a file
does not exist, but a subsequent call to fexist() says it does.

Modified Files:


src/sbbs3/js_msgbase.c
diff

Address MSVC warning and likely Coverity defect CID 516448

Modified Files:


src/smblib/smbdefs.h
diff

src/smblib/smblib.c
diff

src/xpdev/gen_defs.h
diff

Add/use BITFIELD macros for defining/using multi-bit bit-fields

Modified Files:


src/smblib/smbdefs.h
diff

Fix off-by-one error in date/time field bit-mask calculation

This became apparent when the the LSB of the day got set (an odd
day). Oops.

This only impacted decoding of date/time, not encoding.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/writemsg.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

Encode local wallclock (not time_t) in SMB's when_t.time

Increment SMBLIB version to 3.10

Fix issue #845: Changing system/OS time zone, changes dates/times of posted
messages

Sysops and users shouldn't notice any change unless they change the time zone
of their system/OS (not accounting changes for daylight/standard time) and
the result will be that message dates appear the same after such a change.

For backward compatibily, any stored time_t's in msghdr_t.when_written.time
(i.e. all existing SMB messages) will still be decoded and displayed properly.
We detect a time_t value by the upper 6 bits being non-zero. When the upper
6 bits of a when_written.time value are zero, then we know the 'year' is
stored in the 16-bits before the when_written field (never used bits of the
netattr field, now part of the when_t structure definition) and the Month,
Day, Hour, Minute, and Second of the wallclock at the poster's site are
encoded in the low 26 bits of the time field.

This also eliminates more uses of 32-bit time_t that'll likely start being
a problem 2038 and really fall over and die in 2106. At least messages'
posting dates won't have any issue now. The "when_imported" values could use
a similar treatment someday I suppose - and we could get rid of the
when_imported.zone value as its not really needed we could use those 16-bits
for the when_imported.year.

Didn't change anything with filebases (still using time_t's though the
when_written hdr field isn't used for much with regards to files).

Yes, we could have converted all imported "broken down" message dates to
UTC and continued to store them as a time_t using timegm() instead of mktime()
for conversion to time_t, and I considered that. But we would have needed to
create/use a flag in the message header to indicate such stored date/times
(since they'd have to go through different adjustment for original time zone
before display, basically reversing the logic of all the places we display the
message dates/times using localtime verus gmtime/UTC C RTL functions),
couldn't just initialize the time with a call to time() upon import of local
messages (unless the local timezone happened to be UTC). And in the end, we'd
still have a 32-bit time_t value. So this seemed the better path.

I would have liked to have stored the date fields in a more human readable
encoding (BCD or decimal, ala isoDate and isoTime_t), but I just didn't have
the spare bits in the fixed portion of message headers to be wasteful like
that.

Here's an example from smbutil v of a message header posted after this change:
  when_written     03292595 41E0 Fri Dec 20 18:22:21 2024 PST
  when_imported    6766265D 41E0 Fri Dec 20 18:22:21 2024 PST

Notice the difference in the hex encoding of the date/time between the 2
header fields: when_imported still uses time_t. The when_written.year value
isn't output here.

Modified Files:


ctrl/main.ini
diff

Change security level 0 to be more forgiving

changed from 0 to 1:
 timeperday
 timepercall
 callsperday
 postsperday
 emailperday

There are restrictions to remove access to these features if that's what the
sysop desires.

This will allow unauthenticated mail clients to post a single message (per day)
to a sub-board, when there's a posting alias set up (sub:* in alias.cfg).

Modified Files:


src/syncterm/syncterm.iss
diff

Include both x64 and x86 binaries in install package

... and auto-choose the right one

Tested on Windows 11 (x64) and Windows7-32

Modified Files:


src/syncterm/syncterm.iss
diff

Rename the default setup file to be consistent with SyncTERM 1.1 release

Modified Files:


src/syncterm/syncterm.iss
diff

Updated for SyncTERM v1.3

Don't install the fonts to the syncterm.ini, Deuce says they confuse sysops.

Renamed the setup.exe file due to warning from ISS about security concerns.

Tested on Windows 11.

Modified Files:


src/xpdev/genwrap.c
diff

Only use RtlGetVersion for Windows 10/11

This function appears to truncate the service pack info for Windows 7 (6.1):
"Windows NT Version 6.1 (Build 7601) Service Pack 1 x86" became:
"Windows NT Version 6.1 (Build 7601) S x86"

Don't close the handle to ntdll.dll (hey, that's stupid filename, Microsoft!)
since the module could be unloaded from the address space and then a call to
the captured procedure address could/would crash. This handle will be closed
when the process terminates anyway.

While we're here, correct the Windows 6.1 -> 7.0 numbering. That looks better:
"Windows NT Version 7.0 (Build 7601) Service Pack 1 x86"

Something should probably be done for Windows 6.2 -> 8.0 numbering too, but I
don't have a VM handy. Is anyone actually still running Windows 8.x?

Modified Files:


src/xpdev/genwrap.c
diff

Move the #pragma warning to just before the call to GetVersionEx()

Needed for building sbbsexec.dll

I guess #pramga warning only affects the following source line.

Apparently we're disabling this warning effectively via other means in all
other MSVC projects.

Modified Files:


src/xpdev/genwrap.c
diff

Use RtlGetVersion to get/report Windows 11 (and build number) correctly

This is fun Microsoft. If Windows 11 is actually Windows 10.22000+, what will
Windows 12 be? No one can guess.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add @-codes to display dates/times in UTC

When the system time zone is not UTC, but the sysop wants to display some
dates and times in UTC, they can now use these @-codes to do that:
- TIME_UTC
- DATE_UTC
- UTC:fmt
- DATETIME_UTC
- MSG_DATE_UTC

Modified Files:


src/xpdev/xpbeep.c
diff

I *think* this is "FreeBSD or Solaris"...

Nobody will really care though.

Modified Files:


src/sbbs3/userdat.c
diff

Go back to using non-blocking periodic/polling user.tab lock attempts

This partially reverts commit 03b84df85.

I observed deadlocks on Linux attempting locks of user.tab on Samba share,
which also deadlocked my Windows nodes. Interestingly, the Windows nodes
never deadlocked on their own (after a week of testing) when using blocking
locks.

Double the frequency of lock retries - this has helped reduce the observed
user.tab lock failures on Vertrauen.

Modified Files:


ctrl/main.ini
diff

src/sbbs3/js_system.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

Removed Files:


web/root/rss.ssjs
diff

Add "Auto" Local Time Zone option and make that the default for new install

As Deon pointed out in DOVE-Net / Synchronet Discussion, having a local time
zone configured with a different UTC offset than your system time zone can
produce strange/unexpected results (e.g. displayed age of messages). Since
it's possible that not all sysops will complete the configuration wizard or
actually set their timezone to the correct value (and ignore the startup
warning message), we now make the default Local Time Zone to be
"automatic" - query the OS every time the local time zone is needed/used.

This has the downside of only storing (e.g. in message headers) the UTC
offset of the current time zone (not the time zone abbreviation/name as
encoded by SMB). I considered making an option to dynamically figure out
the actual time zone (not just the UTC offset) and while I think that's
doable, Deon just wanted his UTC offset (e.g. UTC+11:00) and not his
time zone name (e.g. AEDT) stored in message headers, so this setting
would be the behavior he expected/wanted.

I'm using the sentinel time zone value of -1 for this new behavior.

Existing configurations (behavior of existing systems) aren't changed.

Added Files:


exec/rss.ssjs
diff

Updated for webv4 and fix off-by-one error reported by LaF0rge

Make the scheme ("http://" or "https://") configurable via rss.ini, default is
now "https://".

Make the message link format somewhat configurable via rss.ini (hopefully to
support some other/future web message reading interface should there be one).

Reportedly, the MsgBase.get_msg_header/body() calls of the "total_msgs" offset
were logging errors? I was not able to reproduce this (the !hdr check seemed
to be successfully ignoring such cases), but in any case, message offsets are
0-based, so this was definitely an off-by-one issue, even if it was a silent
failure for everyone else. <shrug>

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Fix default for "U.S. Time Zone" toggle when west of UTC

... when current timezone is negative offset from UTC, but not a US time zone,
the default should be "No".

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_scrolling_read_input_timeout_fix' into 'master'

DDMsgReader bug fix: In the scrolling message reader interface, it now exits on
user input timeout (as it should). This should fix issue #844, reported by
Keyop

Closes #844

See merge request main/sbbs!483

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader bug fix: In the scrolling message reader interface, it now exits on
user input timeout (as it should). This should fix issue #844, reported by
Keyop

Modified Files:


3rdp/build/cl-no-musl-backtrace.patch
diff

Well, that didn't work, just disable the backtrace on Linux

Presumably it's because I'm not using std=gnu11 or whatever

Added Files:


3rdp/build/cl-no-musl-backtrace.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

We can't do a backtrace using musl

Use the same hack as for strerror_r()

Modified Files:


src/sexpots/sexpots.c
diff

include signal.h for signal()

Modified Files:


.gitlab-ci.yml
diff

Add alpine linux build (no JS)

Modified Files:


src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

Move USE_ALSA_SOUND detection into Common.gmake

Added Files:


3rdp/build/cl-musl-socklen_t.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Add patch for socklen_t with musl

Modified Files:


src/xpdev/genwrap.c
diff

Attempt to fix musl builds

The non-standard strerror_r() is glibc specific, musl doesn't do
that.  It *appears* that __USE_GNU implies glibc.

Modified Files:


docs/v320_new.txt
diff

Document more changes

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs.h
diff

Add/user sbbs_t::getuseron() for better user.tab error logging/handling

Looking into potential causes of issue #843, I found several instances where
we call getuserdat() without checking the return value and restoring the
useron.number to the current user number upon error: getuserdat() zeroes out
the user struct/number upon error, a bad API choice made 23 years ago.

Replace those instances with calls to sbbs_t::getuseron() which logs any
open/lock/read failures of the user.tab and does not modify/zero-out the
sbbs_t::useron struct upon error.

Modified Files:


src/sbbs3/websrvr.c
diff

Whitespace change only

Modified Files:


src/sbbs3/userdat.c
diff

Remove the config check from openuserdat()

... since all (almost all) callerd do a config check first.

Also, some callers of openuserdat() were expecting -1 on failure (always).

Functions that returned the return value of openuserdat() upon failure, now
return USER_OPEN_ERROR instead, to be consistent.

Modified Files:


src/sbbs3/useredit.cpp
diff

openuserdat() was recently changed to not always return -1 on error

Modified Files:


src/sbbs3/services.c
diff

Lower severity of repeated error messages in js_ErrorReporter()

A copy/paste from websrvr.c

Added Files:


install/net.synchro.sbbs.plist
diff

A macOS/darwin launchd service/daemon file

... that is working (for me at least) to auto load/rerun sbbs

Modified Files:


src/sbbs3/websrvr.c
diff

Better NULL ptr checking in js_ErrorReporter, CID 516068

Modified Files:


src/sbbs3/websrvr.c
diff

Use errprintf() instead of lprintf() for one more log message

Modified Files:


src/sbbs3/websrvr.c
diff

Lower severity of repeated errors in js_ReportError()

This needed a custom solution (not errprintf) since the filename is passed-in
is likely from dynamically allocated memory, so a pointer comparison isn't
enough - and we don't get the function name.

Modified Files:


src/sbbs3/email.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Convert CP437 message subject to UTF-8 when posting a UTF-8 encoded message

This is a solution for issue #842, but only for messages posted/sent from the
terminal server using built-in functions and not via JS or other means. A more
universal/generic solution would be nice (beyond just always storing message
headers and bodies in UTF-8), but nothing has come to mind.

Modified Files:


src/sbbs3/main.cpp
diff

Always unlock nodefile_mutex before calling errormsg()

Modified Files:


.gitlab-ci.yml
diff

Revert "Disable darmwin-x86" - the x86 mac mini has a new home

This reverts commit 79fa3c0bb8d46fb4e3730eddb9926c5aa15b8b7c.

Modified Files:


src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

Add support for bytearray

Differently than all other types, the length must be set before
parsing because the BPP does not contain the length data, instead
the length is specified by the message definition.

Modified Files:


src/ssh/comp/none.c
diff

src/ssh/deucessh.h
diff

src/ssh/enc/none.c
diff

src/ssh/mac/none.c
diff

src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

Remove the expectation of dynamic memory in parsing packets

The expectation is now that there will be a single copy of SSH BPP
contents and arrays and buffers will be pointers into that.

Modified Files:


src/ssh/deucessh.h
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh.c
diff

Move the transport state into the session struct.

This avoids another allocation/free requirement.

Added Files:


src/ssh/deucessh.h
diff

Modified Files:


src/ssh/client.c
diff

src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.c
diff

Rename ssh.h -> deucessh.h, clean up includes

All consumers are expected to only #include deucessh.h now.  Individual
headers should not be included.

Modified Files:


webv4/lib/events/nodelist.js
diff

Support custom node status and activity new to v3.20

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add missing space to JSDOC HTML output

Modified Files:


webv4/lib/events/nodelist.js
diff

presence_lib.js no longer defines extended_status

So require(..., 'node_status') instead. The function we actually use here.

Modified Files:


webv4/root/api/system.ssjs
diff

presence_lib no longer defines extended_status()

and we weren't using that function here anyway, so require(..., 'node_status')
instead.

Modified Files:


src/sbbs3/text_defaults.c
diff

Corrected text string numbers in comments (that's all, I think)

Modified Files:


src/xpdev/dirwrap.c
diff

Fix bug in recursive use of delfiles(), not deleting all subdirs/files

Looks like this feature (commit d661427e13) never really worked correctly
since it counted the files removed from each sub-dir and then stopped deleting
when the count reached the number of files in the base directory. This was
done to accommodate the 'keep' feature (part of previous commits).
So make 'keep' check conditional on it being non-zero and just don't ever use
a non-zero keep value with a recursive delete and we should be good! :-)

This fixes issue #841

Modified Files:


src/sbbs3/services.c
diff

Add/use errprintf() to lower severity of repeated error messages

part of fix for issue #619

Modified Files:


src/sbbs3/websrvr.c
diff

Add/use errprintf() to reduce severity of repeated error messages

Part of solution for issue #619 (for the web server)

Modified Files:


src/sbbs3/mailsrvr.c
diff

Add/use errprintf() to reduce severity of repeated error messages

Part of solution for issue #619 (for the mail server)

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Support text.dat string IDs (string) args for replace/revert_text() funcs

For alignment with the text() method and for instances where a script author
doesn't want to load('text.js') or use [bbs|system].text.ID to get a text.dat
string index from an ID.

Modified Files:


src/sbbs3/postmsg.cpp
diff

If user doesn't modify the replied-to-msg subject, use the original subject

(which might be UTF-8 encoded). This works-around the problem that Accession
reported in #synchronet with my reply to a UTF-8 encoded message using a CP437
terminal which resulted in a message body that was UTF-8 encoded but a message
subject that was CP437 encoded. This mix of encodings is not supported by FTN
standards.

This is just a work-around since if the user modifies the subject the result
could still have the CP437 unside-down question marks (indicating
non-translatable UNICODE chars) and those should be converted to UTF-8
chars when going out on FTN or being stored in the message base. So there's
still a bug here somewhere that I need to look into more.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix off-by-one usage of snprintf() when copying message subject

- when converting from CP437 to UTF-8
- when reading from RESULT.ED drop file

This effectively limited message subjects in some instances to 69 chars
instead of 70. This bug was caught while debugging a replied-message subject
conversion from UTF-8 to CP437 issue reported by Accession.

Modified Files:


exec/default.js
diff

exec/str_cmds.js
diff

Add RELOAD sysop command to reload a (JS) command shell without logoff/on

We have to use load() (rather than js.exec) to invoke str_cmds.js so that an
exit() will actually exit. Since load() automatically does the mods vs exec
directory search-dance, that simplifies the code in default.js a little.
I'm not sure exactly why I originally chose to use js.exec() over load() for
invoking str_cmds.js, but for this feature, we need load() so let's go with
that for now.

I did encounter an issue (issue #840) while originally trying to make this
work with the original code that called js.exec(), but just punted and went
with load() instead. Perhaps if we fix issue #840, we can revert default.js
back to using js.exec() (but why we would need/want to, I'm not sure).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_metadata_desc_undefined_fix' into 'master'

ddfilelister: Check whether 'desc' is a string in file metadata before trying
to use it. Should fix issue #839

Closes #839

See merge request main/sbbs!482

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Check whether 'desc' is a string in file metadata before trying
to use it. Should fix issue #839

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/putnode.cpp
diff

Fix use of unitialize variable

Since we we're not using opennodeext(), we don't have the path/fname for
any failure error message here.

CID 515714

Modified Files:


src/sbbs3/userdat.c
diff

Fix incorrect use of sizeof in node_vstatus and node_activity

This would cause the "Logout" status and multinode chat activity
strings to be truncated to 3 or 7 chars.

CID 515713 and 515715

Modified Files:


src/ssh/ssh-trans.h
diff

We need separate context for client to server

Modified Files:


.gitlab-ci.yml
diff

Disable darmwin-x86

System is going on a trip.

Modified Files:


src/sbbs3/getnode.cpp
diff

Reset/send status attr after activity, which could include Ctrl-A codes

Modified Files:


src/sbbs3/userdat.c
diff

Insure ctrl chars/codes are stripped from nodestatus() output

Use strlcpy instead of strncpy

Modified Files:


exec/load/presence_lib.js
diff

Insert stats prefix after activity, in case it contains attr codes

Modified Files:


exec/fingerservice.js
diff

Use new node (customizable) activity, if available (and strip ctrl chars)

This allows customized node actions/activity to be sent over finger/activeuser
(so visible in sbbsimsg.js for example).

Modified Files:


src/sbbs3/gtkmonitor/gtkmonitor.c
diff

src/sbbs3/umonitor/umonitor.c
diff

Load text.dat to get customized node status strings from text.dat/text.ini

Modified Files:


ctrl/text.dat
diff

exec/load/presence_lib.js
diff

exec/load/text.js
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/MainFormUnit.h
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Overhaul how custom Node actions and status strings are handled

Custom NodeStatus and NodeAction/Activity strings are now displayed pretty
much everywhere possible (except the node utility, since it doesn't read
any configuration files). This fixes issue #618, finally.

If you have custom (non-blank) NodeAction* strings in your text.dat/text.ini
file, or you change these strings during runtime (e.g. using bbs.replace_text)
this will impact you:
- do not include the user name or any other fields normally included in
  printed node status in your string - just the customized node action and
  really, you should only use/override these strings for dynamically changing
  node status (i.e. you're using NodeActionCustom and you're setting different
  custom strings depending on current node activity). Consider using the new
  NodeActivity* text.dat strings instead if your customized string doesn't
  change during run-time.
- don't use the %s/%u/%d specifiers any more - use @-codes instead, if needed

If you want static/permanent node action strings, set new new NodeActivity*
strings in your text.dat or (preferrbaly) text.ini file instead.
This means the node actions can now be localized for other languagues!

I'm still using the node.exb file (I did consider alternatives, e.g.
node.ini or node*/activity.asc), but decided to postpone such a change.
The node.exb file is still used, but the strings represent just the custom
(extended) node *activity* and not the entire node status string.

Use of Ctrl-A codes needs to be considered/accounted-for (currently isn't).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix the areas.bbs AreaMgr addition bug created in commit 813072cd450c2

The newly created/used link_aera() function was copying the address of the
passed fidoaddr_t pointer rather than the value (fidoaddr) pointed to.
This is the actual fix for the problem reported by Tom Moore (1:135/205)
- tested and validated. It only immediately impacted areas.bbs use
(not areas.ini), since we wrote a stringified address directly to the
areas.ini file "links" key. This was not an allocation issue but a memcpy()
issue.

Other unrelated changes:
- Log a debug-level message when ignoring a "NO-ECHO" message (subject "NE:*")
- Log a notice-level message when ignoring a message due to GATEWAY VIOLATION
  (gating a message between net-types when not explicitly configured to do so)

Modified Files:


src/sbbs3/sbbsecho.c
diff

A differnt 'fix' to link_area()

So, (sizeof *addr) now looks right got me (this should've been the same as
sizeof(fidoaddr_t)), so the change in commit e2476ebbaa doesn't actually look
like a fix, but maybee a regression.

I need to test some area manager link additions and get to the bottom of this,
but this particular change was not a fix (and caught/reported by Coverity -
CID 515673).

Added Files:


src/ssh/comp/none.c
diff

src/ssh/comp/none.h
diff

src/ssh/enc/none.c
diff

src/ssh/enc/none.h
diff

src/ssh/mac/none.c
diff

src/ssh/mac/none.h
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/client.c
diff

src/ssh/ssh-trans.h
diff

Add the "none" encryption mac and compression drivers

This is not the "hard part" I meantioned earlier. :D

Modified Files:


src/ssh/client.c
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

Eliminate egregious and unneeded allocations.

Modified Files:


exec/automsg.js
diff

Fix typo: bbs.node_action, not bbs.action

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix insufficient allocation bug in link_area() introduced in commit 813072cd4

This is likely the cause of the areamgr issue that resulted in weird/invalid
node address being added to the area file, reported by Tom Moore (1:135/205).

Modified Files:


src/sbbs3/ctrl/EventsFormUnit.cpp
diff

src/sbbs3/ctrl/EventsFormUnit.h
diff

Update comment header blocks to remove CVS references and such

Modified Files:


src/sbbs3/main.cpp
diff

Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

There still appears to be some race condition with network (Samba) FS
directory caching and opening/locking of files, so it does seem illogical that
the packet file wouldn't exist at this point (since we have the lock file
opened) but this does still happen on occasion on Vertrauen.

Modified Files:


src/sbbs3/un_rep.cpp
diff

Eliminate some redundant log output in Unpack REP failure condition.

Modified Files:


src/sbbs3/js_console.cpp
diff

Parse console.inkey() timeout parameter as an *unsigned* integer

A negative timeout value doesn't make sense and this will extend the legal
(positive) range of this parameter value.

Hopefully this will help eliminate these errors I get often:
  dd_lightbar_menu.js line 4041: Error: can't convert inputTimeoutMS to an
  integer

But if there's some way that this parameter value is even out of the range of
an unsigned 32-bit value (4294967295) then this error could still happen.
Unfortunately, the JS exception doesn't report the value that failed to
convert.

Modified Files:


src/sbbs3/logon.cpp
diff

Check return value of getnodedat()

Should fix CID 515599 since this seems to be the only place we call
unlocknodedat() without possibly not owning the nodefile_mutex already.

Modified Files:


src/sbbs3/putnode.cpp
diff

More nodefile_mutex fixes

Need to unlock the mutex before calling errormsg().

Need unlock the mutex in error path of unlocknodedat().

I'm not clear why this would, but it might resolve CID 515601 which looks
like false positive to me: getnmsg()->putnodedat() should never leave
nodefile_mutex locked.

Modified Files:


src/sbbs3/load_cfg.c
diff

Check return value of smb_create() in smb_open_dir()

Resolves CID 515657

Modified Files:


src/sbbs3/readmail.cpp
diff

Always free(mail)

I don't think this was actually a leak (since smb.msgs should be non-zero
any time mail is non-null), but to make Coverity happy (CID 515659) and just
be more fault-tolerant, always free(mail).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_list_select_msg_move_to_next_refresh_fix' into
'master'

DDMsgReader: Screen refresh fix for selecting messages when automatically
moving to the next message at the menu's last row on the screen

See merge request main/sbbs!481

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Screen refresh fix for selecting messages when automatically
moving to the next message at the menu's last row on the screen

Modified Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

And add the hooks for the rest of the transport stuff

Should be possible to implement the hard stuff now, though it won't
actually be testable until the KEX bits exist too.

Smooth sailing after that though.

Modified Files:


src/xpdev/dirwrap.c
diff

Optimize mkpath()

If the path already exists (is a directory), don't need to check each path
element for existence.

This should help with the speed of saving of large file.ini (Nelgin's) when a
lot of directories have "Check for File Existence" set to "Yes".

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Verify QWK messagse files (e.g. MESSAGES.DAT) is multiple of QWK block size

(128 bytes)

Fix up the filename in error messages reported during unpacking QWK packets
(MESSAGES.DAT not BBSID.QWK).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Truncate the GIT date (remove time) in Program ID.

Modified Files:


src/sbbs3/msg_id.c
diff

Fix GIT date truncation (e.g. "202" instead of "2024") in program-ID

Modified Files:


src/xpdev/filewrap.h
diff

Resolve Borland build warning: missing xp_lockfile() prototype

Modified Files:


src/xpdev/filewrap.c
diff

Appears MinGW requires '_locking' Borland requires 'locking' and MSVC does both

Modified Files:


src/xpdev/filewrap.c
diff

In Boland's io.h, this function is just called locking()

Modified Files:


src/xpdev/filewrap.c
diff

Need locking.h here for Borland C++ build

Modified Files:


src/xpdev/filewrap.c
diff

Move the xp_lockfile() into a compile block that includes Borland

Modified Files:


src/xpdev/filewrap.c
diff

Fix typo in Windows version of xp_lockfile()

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Introduce/use errprintf() for de-duplicated/prioritized error logging

Convert more log messages to use de-duplication as solution to issue #619.

A lot more lprintf() -> errprintf() conversions will be needed to fully
realize this solution (e.g. in the mail, ftp, web, services serverss).

Modified Files:


src/sbbs3/prntfile.cpp
diff

Add "Printing file" and "Printing tail" debug-level log messages

In printfile() and printtail() which are used by menu() and many other
functions.

These should be helpful to sysops that just want to know what file is being
displayed under what conditions (e.g. for trouble-shooting or customization
reasons).

Modified Files:


exec/webfileindex.ssjs
diff

Display directory aliases from web_alias.ini as shortcuts on index page

Other kinds of aliases are supported in web_alias.ini (e.g. libraries, files)
but not displaying those here (yet).

Modified Files:


exec/load/tree.js
diff

Address occasional TypeError: this.current is undefined

Modified Files:


src/sbbs3/userdat.c
diff

Make user_downloaded_file() tolerant of being passed a file path

... instead of just the file name, as was expected.

Modified Files:


webv4/root/api/files.ssjs
diff

user.downloaded_file() expects *just* the filename, not a full path

This is why files downloaded via ecWebv4 haven't been properly accounted.

Modified Files:


src/sbbs3/userdat.c
diff

src/xpdev/filewrap.c
diff

src/xpdev/filewrap.h
diff

Add/use xp_lockfile() to support blocking file range/region lock acquisition

Under heavy loads, I've found periodic non-blocking lock attempts just aren't
reliable enough: in particular, on Vertrauen, the guest user account record
in the user.tab file gets read and written-to A LOT (updating stats), and
under heavy loads (especially with hundreds of web client sessions), I'd get
timeouts attempting to lock the guest record in the user.tab (after about a
minute of periodic retries) - so let's just block "forever" to get the user
record lock (or until signaled or notified of a deadlock). With this change,
I've not had any user.tab lock errors or apparent deadlocks.

Let the underlying OS/filesystem handle queuing and deadlock detection,
when supported. lock() still behaves as before: non-blocking lock attempt.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_indexed_newscan_no_snap_selection_bug_fix' into
'master'

DDMsgReader: Bug fix - For indexed newscan without snap-to-new, ensure it
remembers the user's previously selected sub-board (reported by Keyop)

See merge request main/sbbs!480

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Bug fix - For indexed newscan without snap-to-new, ensure it
remembers the user's previously selected sub-board (reported by Keyop)

Added Files:


src/ssh/client.c
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/ssh-trans.c
diff

src/ssh/ssh.h
diff

Add a test client and fix a couple bugs.

Modified Files:


exec/addfiles.js
diff

Overhaul the help output and display valid lib names when helpful

- If sysop specifies an invalid lib name, show them what the valid names are
- Make it clear that the directory specified (dir-spec) is either a combination
  of -lib and -dir *or* -all *or* dir-code *or* nothing (a get prompted)
- When using -all, clear the list of specified directories to prevent dupe
  dir scanning when misused.

Modified Files:


exec/addfiles.js
diff

Allow any-case for library name used with -lib=name option

Modified Files:


exec/addfiles.js
diff

Auto-convert specified directory codes to lowecase

Modified Files:


exec/addfiles.js
diff

Allow a comma-separate list of dir-codes to be passed to -dir option

Modified Files:


exec/addfiles.js
diff

Add -dir=<code> option to manually specify multiple directories

As requested by Nelgin.

And this option is mutually exclusive with the [dir-code] parameter.

Modified Files:


src/sbbs3/logfile.cpp
diff

De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity

... from ERROR to WARNING, so the repeats won't be logged to error.log file
and won't (normally) be sent as notifications (e.g. emails) to the sysop. The
duplicates are identified as from the same source file and line number as the
immediately previous logged error within the last 12 hours. String comparison
doesn't really work for deduplication since if you look closely, the errors
usually are *not* exact duplicates (i.e. there's a node number or a socket
descriptor or something that uniquely identifies the user/client/session).
Repeated errors don't increment the node's error counter either.

This does not de-duplicate errors logged via other means (e.g. direct calls to
log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
solve the majority of duplicate errors that can be logged from the terminal
server.

So this at least partially addresses issue #619.

Modified Files:


src/xpdev/filewrap.c
diff

Clean up the OFD check/decision, make use of fcntl() locks easier to opt-in

Modified Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.c
diff

src/ssh/ssh.h
diff

More transport work.

Next step is to implement a KEX.

Modified Files:


src/comio/comio_nix.c
diff

Enable ISTRIP mode when fewer than 8 bits are requested.

With this, SyncTERM and SexPOTS on *nix won't actually need to strip
received bytes themselves.  No idea what Windows does though, so
it'll likely still be needed forever.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_option_listing_msgs_select_goes_to_next_msg' into
'master'

DDMsgReader: New user option & behavior: In a message list, when
selecting/toggling a message, it can now optionally move the cursor to the next
message

See merge request main/sbbs!479

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: New user option & behavior: In a message list, when
selecting/toggling a message, it can now optionally move the cursor to the next
message

Modified Files:


exec/avatars.js
diff

.ini files need to be opened for read/write access when writing/updating

This happened to work before commit d49134e6f7 since iniReadFile()
didn't return false upon any read error, so File.iniSetAllObjects() didn't
realize that the read of (any) existing file contents had failed (because the
file was open write-only).

This explains why the *.avatars.ini files were pretty much blank as of late
and no networked message posters were having their avatars displayed.
Reported by Codefenix (thank you).

Add a print/log line to tell us how many avatars were parsed, just for extra
traceability of this script and any potential failure cause.

Added Files:


src/ssh/ssh-trans.c
diff

src/ssh/ssh.c
diff

Modified Files:


src/ssh/CMakeLists.txt
diff

src/ssh/portable.h
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

The start of the transport layer and the public API.

Added Files:


src/ssh/portable.h
diff

Modified Files:


src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

Introduce portable.h for ugly hacks

The plan is to hide non-standard stuff in here.  Currently, just
has [[maybe-unused]] from C23.

Modified Files:


src/ssh/CMakeLists.txt
diff

Use FindOpenSSL instead of pkg-config for OpenSSL

Added Files:


src/ssh/CMakeLists.txt
diff

src/ssh/ssh-arch.c
diff

src/ssh/ssh-arch.h
diff

src/ssh/ssh-trans.h
diff

src/ssh/ssh.h
diff

Start of DeuceSSH

The intent is that this will be a library implementation of SSH
which allows simple extension of the base protocol, and exposes all
defined features of the protocol (including ones nobody uses).

This will support both client and server, with initial focus on the
client implementation for use in SyncTERM.

The goal of the core library is to only support the most secure
standard methods.  When there are multiple methods that are not
clearly of differing levels of security, the most common two will
be implemented (ie: RSA and Ed25519).

Additionally, care will be taken during development to allow for
the OpenSSH Encrypt-then-MAC MAC modes in the expectation that
someone will standardize an ETM mode at some point, and I expect
to write an extension to support it soon after DeuceSSH is
complete.

Finally, if I cannot mitigate Terrapin without non-standard
extensions, the OpenSSH "strict KEX" extension will be supported
until there's a standard defined that solves the issue.

Modified Files:


src/sbbs3/nopen.c
diff

On Windows, lock the opened mutex file to insure *nix sopen() will fail

Even though we use O_EXCL, networked file systems still sometimes allow the
secondary open() to succeed. We use record locking in xpdev's sopen()
implementation for *nix, so this lock will insure such opens (and locks) will
now fail.

This is an attempt to address occassional error on Vertrauen:
ERROR 2 (No such file or directory) renaming *.rep to *.bad

Modified Files:


src/sbbs3/un_rep.cpp
diff

Log an info-level message before unpacking a REP packet

Modified Files:


src/sbbs3/userdat.c
diff

Check return value of writeuserfields() in putuserstr()

Return correct error value upon seek failure.

Modified Files:


src/xpdev/filewrap.c
diff

Don't use flock() in sopen() since it ends up using non-OFD fcntl() locks

When OFD locks are available, that's what we should be using.
Otherwise, we suffer the horrible behavior of POSIX file/region locks and
a subsequent open/close of the file releases any/all locks on it.

This is currently in an !BSD block, which appears to include macOS, but
macOS *does* support OFD locks, so I'll be fixing that here shortly.

Modified Files:


ctrl/text.dat
diff

Add NodeActionCustom (blank, by default)

Modified Files:


src/sbbs3/getnode.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/userdat.c
diff

Handle NODE_CUSTOM action and print default node status

"performing custom action"

Normally, the sysop would set the NodeActionCustom text.dat string
to override this.

Modified Files:


exec/load/nodedefs.js
diff

exec/load/text.js
diff

Add the new NodeCustom action

Modified Files:


src/sbbs3/nodedefs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Define custom node action value

This is to be used (e.g. instead of NODE_BXFR) for sysop-custom node actions.

Modified Files:


src/sbbs3/getnode.cpp
diff

White-space changes only

Modified Files:


src/sbbs3/putnode.cpp
diff

Support @-codes in NodeAction text.dat strings

Modified Files:


src/sbbs3/userdat.c
diff

Add random jitter to lockuserdat() and putnodedat() retry delays

so that if multiple entities call these functions at the same time, they
don't retry at exactly the same times.

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sexyz.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/websrvr.c
diff

Use SOCKET_ERRNO instead of (now deprecated) ERROR_VALUE macro

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Add/use SOCKET_ERRNO (in place of ERROR_VALUE)

Modified Files:


src/xpdev/xp_syslog.c
diff

Eliminate unused variable

Modified Files:


src/xpdev/sockwrap.h
diff

Borland C++ apparently doesn't support inline functions (!)

Modified Files:


src/sbbs3/js_global.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/services.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Make socket errno and string descriptions easier to get/use

Add/use SOCKET_STRERROR which gets the description of the *last* socket
error.

We should start using socket_errno(true) in place of ERROR_VALUE (horribly
named macro) for comparing last socket error nubers against values/macros
from errno.h.

Eliminate get_socket_errno(), unused and redundant with socket_errno().

Modified Files:


src/xpdev/sopenfile.c
diff

Add -c and -R options

Really need to make the option order (arity) neutral

Modified Files:


src/sbbs3/ver.cpp
diff

Fix strlcpy() usage

Modified Files:


src/xpdev/sockwrap.c
diff

Fix typo in get_socket_errno() definition

Modified Files:


src/sbbs3/main.cpp
diff

Log the error description upon failure to send on socket

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/con_hi.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/execnet.cpp
diff

src/sbbs3/fido.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_system.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/sftp.cpp
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/ver.cpp
diff

Replace sprintf() calls with snprintf()

Addresses Clang warnings about deprecation

Modified Files:


src/build/Common.gmake
diff

Add -L to LDFLAGS, not CFLAGS for macos builds

This fixes all the "argument unused during compliation" warnings

Added Files:


3rdp/build/cl-dont-validate-va-list.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Fix idiodic check that a va_list != NULL

This breaks armv7 FreeBSD builds.  Presumably it breaks anything
else where va_list isn't a pointer too... and there's no real reason
to expect a va_list to be a pointer except "it's a pointer on the
platform I looked at".

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Unify the int return values of userdat.c functions

These functions now return a common set of non-zero error values (where
appropriate), defined in userdat.h

Don't return errno.

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/bulkmail.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/putnode.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Simplify the getnode.cpp API - use bool returns, default paramaeter value

getnodedat() now performs a non-locked read by default.

Perform more checks of getnodedat() return value before calling putnodedat()
to avoid unintentionally zeroing out node.dab records.

Add/use unlocknodedat() method for unlocking a node.dab record without
writing.

Note: The userdat.c getnodedat() and putnodedat() still return int (i.e. 0 on
success), so that can be confusing.

Modified Files:


exec/freqitcfg.js
diff

Don't call uifc.bail() repeatedly

Since this script already sets an on_exit() handler to call uifc.bail()
it doesn't have to call it again (technically, before) in the "Done" block.
This results in "UIFC is unitialized" error displayed, as reported by
Fernando Toledo. Fixing issue #830

Set WIN_ESC (remains active, but greyed when ESC key pressed) mode flag
on main menu while we're here. That looks better.

Modified Files:


src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.h
diff

Add max concurrent connections edit box to web cfg dialog

Modified Files:


exec/load/newsutil.js
diff

When the originating address is the same as the name, just include one

There's no need to be unnecessarily redundant in the From header, e.g.
From: "scan-admin@coverity.com" <scan-admin@coverity.com>

Modified Files:


exec/load/newsutil.js
diff

MIME-encode To and From header fields that contain non-ASCII chars

This fixes the display of gitlab pushes from Deucе in conforming news readers.

Modified Files:


src/sbbs3/websrvr.c
diff

Track and report the concurrent connections per client highwater mark

It's possible now for clients to easily exceed the configured max concurrent
connections limit, even though they just get an error 429 page. Let's at least
track and log when a new highwater mark is reached.

Modified Files:


exec/nntpservice.js
diff

More RFC (3977) conformance

Some of the NNTP commands (e.g. LIST) aren't supposed to change the "currently
selected newsgroup". Had to use a different variable name (e.g. mb versus
msgbase) since these message base variables share the function scope).

GROUP and LISTGROUP commands are supposed to set the "current article number"
to the first article in the group. We weren't doing this.

The HEAD, BODY, STAT, and ARTICLE commands aren't *required* to have arguments
and yet, we required they had at least one argument (an article number). Now
fixed.

Enabled "strict mode" even though that didn't catch the colliding 'msgbase'
variable definitions.

Incremented the revision to 1.2

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_clear_after_menu_draw_fix' into 'master'

DDLightbarMenu: When clearing the remainder of the screen after drawing the
menu, ensure the console attributes are reset. Also, refactored that section of
code.

See merge request main/sbbs!478

Modified Files:


exec/load/dd_lightbar_menu.js
diff

DDLightbarMenu: When clearing the remainder of the screen after drawing the
menu, ensure the console attributes are reset. Also, refactored that section of
code.

Modified Files:


exec/load/mimehdr.js
diff

exec/load/newsutil.js
diff

Create/use mimehdr encode() method for MIME/Q-encoding UTF-8 header fields

Use it in newsutil get_news_subject() when no original (RFC822)
Subject header field exists.

This should fix issue #817.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Eliminate some harmless gcc warning about using uninitialized vars

Modified Files:


src/sbbs3/logon.cpp
diff

Move the backup of dsts.ini before opening the file

Can't backup (make copies of) an open file.

Added Files:


web/root/error/429.html
diff

Add 429 error page

Modified Files:


src/sbbs3/websrvr.c
diff

Since this is after client_on() is called now, use > not >=

Modified Files:


src/sbbs3/websrvr.c
diff

Move max concurrent connections check into http_session_thread()

We can't send a 4xx error (ie: client did something wrong) in
plaintext on a TLS connection.

Untested beyond a basic compile check.

Modified Files:


src/conio/Common.gmake
diff

Fix the pipeline that DigitalMan broke.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

Implement max concurrent connections (per IP) limit in web server, default: 10

We have this feature for the FTP, Mail, and Terminal servers (with no default
limit) but crazy abuse of my Synchronet web servers has now made this a
necessity for Vertrauen. A limit of 2 used to be considered reasonable long
ago. Today, 10 seems fair enough. Setting to 0 will impose no max-connections
per IP address (other than the total client limit per server).

Modified Files:


src/conio/Common.gmake
diff

src/conio/GNUmakefile
diff

Fix X11 build option checkbox

Similar problem as PulseAudio, but even grosser.

Modified Files:


src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

Fix PulseAudio build option display

The macro was only define in the xpdev GNUmakefile, not in Common,
so bbslist.c did not know if it was enabled or not, and always
showed it as disabled.

Modified Files:


exec/load/newsutil.js
diff

exec/nntpservice.js
diff

Create/use news_get_from() function, copied from nntpservice.js

Use the fully-formed "From" header field in responses to NNTP
OVER/XOVER and HDR/XHDR requests.

This should fix issue #829 reported by Accession

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Range check argc before deref of argv[1]

Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range
(I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to
crash when calling JS_ValueToString() on it.

Modified Files:


src/xpdev/filewrap.h
diff

Retry file lock/read operations on EIO errors

As seen on MacOS, an SMB shared file can cause the Mac SMB client to report EIO
error on locked-file read or lock attempts. So retry.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyv_cfg.js
diff

xtrn/slyvote/slyvote.js
diff

Merge branch 'ddmsgreader_slyvote_poll_message_show_who_voted_what' into
'master'

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show
who voted on what (mimicking the Synchronet behavior which shows new votes when
the user logs in)

See merge request main/sbbs!477

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyv_cfg.js
diff

xtrn/slyvote/slyvote.js
diff

DDMsgReader & SlyVote: WHen viewing polls, for the person who posted it, show
who voted on what (mimicking the Synchronet behavior which shows new votes when
the user logs in)

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/term.c
diff

Re-order entry fields.

This makes more sense.  Also, ones that are meaningless are hidden
now.

Modified Files:


src/conio/cterm.c
diff

The final fixings for issue 172

Use 0 for "no held mosaic" to avoid confusion around printable bytes.
Store the state of the current cell *before* updating in fix_line()

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/cterm.c
diff

Fix double-height drawing

Top/bottom detection was somewhat broken.
Interestingly, now the previous commit isn't working anymore.
So issue 172 is not quite fixed yet.

Modified Files:


src/conio/cterm.c
diff

Fix up the Prestel "Engineering Test Page" rendering

This was due to two main bugs... the simple one was a type where
the cutoff between separated and contiguous mosaics was incorrect,
which caused the first four separated mosaics to not be displayed.

The second was due to a number of bugs in the Hold Mosaic
implementation.

This fixes the first half of issue 172.

Modified Files:


src/conio/utf8_codepages.c
diff

Fix unicode -> Prestel mapping

We want ASCII to map directly, and unicode values need to be sorted
ascending for bsearch() to work properly.

Fixes Prestel keyboard input not working in GDI mode.

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/cterm.c
diff

Handle 8-bit C1 codes in Prestel mode

If the remote sends 8-bit C1 codes, handle them as though they were
properly escaped.  Since Prestel terminals are 7-bit, these will
never be sent by a proper Pretel system, but apparently some systems
do weird non-standard things.

Modified Files:


ctrl/text.dat
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/text_id.c
diff

Create/use SysopPageNotification text.dat string

to notify sysop (user #1) that they were paged. Previously, this was
a hard-coded string. The new string in text.dat is the same, but adds
2 BELs (CTRL-G chars) and is now customizable.

Created an sbbs_t::notify() method to make this easier to use and that
method supports @-code expansion, so this text.dat string supports @-codes
(which I used).

This addresses the feature request in issue #828 (beep the sysop in the
telegram/short message, when they're paged).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_index_newscan_skip_subboard_fix' into 'master'

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards
that have new messages, ensure the selected item index is correct when
re-populating the menu so that it doesn't skip a sub-board. Reported by
Amessyroom.

See merge request main/sbbs!476

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader bug fix: For the indexed-mode newscan, when showing only sub-boards
that have new messages, ensure the selected item index is correct when
re-populating the menu so that it doesn't skip a sub-board. Reported by
Amessyroom.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

We're 1.4a now. :(

Modified Files:


src/syncterm/CHANGES
diff

Document the death of SyncTERM 1.2

Modified Files:


src/syncterm/bbslist.c
diff

Fix error in optmap creation

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_edit_file_check_cost_and_times_downloaded_exist'
into 'master'

DDFileLister: When editing file information, check whether cost and
times_downloaded exist in the metadata before accessing them. Reported by
Ragnarok

See merge request main/sbbs!475

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: When editing file information, check whether cost and
times_downloaded exist in the metadata before accessing them. Reported by
Ragnarok

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/PackageInfo.in
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/haiku.rdef
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

SyncTERM is now 1.3a

Modified Files:


src/conio/sdl_con.c
diff

Fix up win_lock mutex usage

Modified Files:


src/sbbs3/echocfg.c
diff

Some minor cleanups of echocfg

1) Initialize saverobot.name since this is checked unconditionally.
   This has a side effect of initializing everything else, but name
   is the only thing that actually matters.
2) Add a bar to the global settings menu.
   Previously, if you scrolled near the bottom and selected an option,
   after changing the option, you would jump up to the last item on
   the initial screen.
3) Fix the AreaMgr Support default value to be the current, not the
   opposite of current.
4) Use the correct variable for EchoMail Relay Filtered Messages
   setting default.

Modified Files:


src/sbbs3/main.cpp
diff

Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.

Modified Files:


src/syncterm/GNUmakefile
diff

Don't create the Framework dir if we won't put anything in it.

Modified Files:


src/conio/sdl_con.c
diff

Remove unused variable

Modified Files:


src/conio/sdl_con.c
diff

Try this the other way...

Modified Files:


src/conio/sdl_con.c
diff

Scale SDL_GetDisplayUsableBounds() like SDL_GetWindowSize()

For retina lies.

Modified Files:


src/sbbs3/getnode.cpp
diff

Fix potential deadlock in getnodedat(), observed on macOS

Upon any node.dab lock or read failure, this code would cause errormsg() which
would often/usually end up claling getnodedat() which would block forever
trying
to acquire the ndoefile_mutex (introduced in commit b9633069, I'm not clear
why).

Unlock/release the mutex *before* calling errormsg().

Modified Files:


src/sbbs3/main.cpp
diff

Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer

Modified Files:


src/sbbs3/echocfg.c
diff

Update Area File help screen to explain areas.ini area file format/option

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Add support for exporting fidonet sub-boards to areas.ini file

Modified Files:


src/conio/sdl_con.c
diff

Deuce said I remove this error message

It was always displayed (sent to stderr) when running scfg, echocfg, uedit,
etc. in auto-curses mode, so suppress that noise.

Modified Files:


src/sexpots/sexpots.c
diff

If configured COM port byte size is less than 8, strip high 8-n bits on RX

Some USB modems (reportedly, USRobotics USB modem) don't strip the parity bit
of data received from modem connections operating in < 8 bit modes
(e.g. 7-E-1), as is normally don't with a modem connected to a UART, so we'll
do that stripping (forcing to 0) here, as recommended by Deuce.

Nelgin, if you're doing some manually stripping of the 7th bit bytes received
from 7-E-1 connected modems and then sent to your server/BBS over TCP, you
shouldn't need to do that now.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Clean up area management code

I dislike this particular code a little less now:
- no more redundant string compares
- less deeply nested if() and for() blocks
- remove added areas from the add list, rather than zeroing out the tag
- a little more common code between areas.bbs and areas.ini handling

No functional change (I hope).

Modified Files:


src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

Add strListFastDeleteAll()

To quickly free and remove all list entries (without realloc).

Modified Files:


src/syncterm/bbslist.c
diff

Remove accidental zero-width unicode character.

Modified Files:


src/syncterm/bbslist.c
diff

Use enum values for field names

Easier to match up than numbers.

Modified Files:


src/syncterm/bbslist.c
diff

Fix editing of name broken in earlier commit, refactor

Split generating help into separate function
- Regenerated when the connection type changes
Split generation the opt list into separate function
- Regenerated after handling any selection

Modified Files:


src/syncterm/CHANGES
diff

Clean up changes list to only "interesting" ones.

If someone wants to know the differences between 1.2rc1 and 1.2rc3,
the can check git.

Modified Files:


src/syncterm/CHANGES
diff

Make the same as the syncterm-1.2 branch

Modified Files:


src/syncterm/CHANGES
diff

Change CHANGE for newest changes.

Modified Files:


src/syncterm/modem.c
diff

The USR modem isn't so bad that it needs parity generated

We just need to strip the high bit on RX because the mode leaves
it on received bytes.

Modified Files:


src/syncterm/modem.c
diff

Resolve recently added compile errors and warnings

to unblock the pipes

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Replace almost all references to AreaFix with AreaMgr or AreaManager

"AreaFix" is a proper product name. Though it's been defunct and unsupported
for decades, we still should not confuse sysops and historians: the general
term for what AreaFix did/does is Area Management, aka Conference Management.

The sbbsecho.ini key names are unchanged and the destination netmail address
for AreaManager requests can still be "AreaFix" (though "SBBSecho" is still
supported as well).

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix stupid inverted logic bug: treating areas.ini as areas.bbs for AreaFix

and vice versa - so area manager requests were broken since I introduced the
areas.ini support. Oops.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Support AreaMgr request messages with -L (list) or -Q (query) but no body

I noticed through code review that these kinds of messages would be rejected
as "No commands to process.". We just needed to increment the 'cmd' counter
when parsing these options to be sure we don't think that no commands were
in fact request. -R (rescan) is not by itself a command since it requires
listed area-tags to have any effect.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Detect and log warnings about duplicate area sections in areas.ini

... like how we do for areas.bbs files.

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniGet/ReadSectionListWithDupes()

For use cases were we don't want to silenty ignore duplicate (secondary)
section definitions.

Modified Files:


src/syncterm/CHANGES
diff

Log changes

Modified Files:


src/syncterm/modem.c
diff

Because some USB modems suck (ie: USR5637), do software parity

This is just in case the modem actually stays in 8N1 mode when
7E1 or 7O1 is set.  This is what the USR 5637 appears to do.

There's a small performance penalty for anything in 7-bit mode with
this, but it shouldn't be enough to actually impact anything.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/modem.c
diff

Drain modem buffer before sending commands.

Modified Files:


src/syncterm/modem.c
diff

Set flow control before raising DTR

Possibly setting CTS/RTS after raising DTR drops DTR which causes
DCD to be lost.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_pollview_responses_fix' into 'master'

DDMsgReader bug fix: When viewing a poll that the user has posted and showing
who voted on the poll, ensure it only counts poll responses (not reply
messages). Reported by nelgin

See merge request main/sbbs!474

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader bug fix: When viewing a poll that the user has posted and showing
who voted on the poll, ensure it only counts poll responses (not reply
messages). Reported by nelgin

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix unsigned compare against >= 0 and nomatch misplacement

I'm not clear if/why these would cause the issue reporetd by
Fernando but they're definitely bugs in the areas.ini areafix
code. No impact to the areas.bbs areafix handling.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix new potential NULL derefs (the add/del_area args can be NULL)

... in area manager code modified in previous commit.

Modified Files:


src/syncterm/bbslist.c
diff

Remove unused variable.

Modified Files:


src/syncterm/bbslist.c
diff

Terminate parity_enum

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/modem.c
diff

Apparently, Windows headers define (at least) PARITY_NONE

Even when "lean and mean".  Rename enum.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/modem.c
diff

Add support for configuring data/stop bits and parity for modem and serial

Also, straighten out the confusing option adjuster thing when editing
an entry.

The help text still needs an overhaul, but now I have to re-test this
whole mess.

Modified Files:


src/syncterm/CHANGES
diff

Log changes

Modified Files:


src/syncterm/modem.c
diff

Explicitly set serial port to 8N1

Surely nobody uses anything else...

Modified Files:


src/sbbs3/download.cpp
diff

src/sbbs3/sbbs.h
diff

Save and restore the Telnet BINARY_TX option state separate for each direction

It's possible the client requested binary transmit in only one of the two
directions and if so, restore just the direction that was previously *not*
in binary transmit mode to NVT mode.

Modified Files:


src/sbbs3/main.cpp
diff

request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass
those values back to request_telnet_opt() with no side effect.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

src/syncterm/syncterm.c
diff

Fix crash when editing blank "extra" bbslist entry
Show current list path, not default in File Locations
Support copy/paste in BBS list

Modified Files:


src/conio/allfonts.c
diff

src/syncterm/CHANGES
diff

Add blank pixel to left and top of Prestel DEL glyph

Makes the Night Owl BBS login screen look more accurate.

Modified Files:


src/sbbs3/download.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/xtrn.cpp
diff

Allow Telnet client to be in binary mode persistently

Before this change, we'd always request a return to Telnet NVT (turn off
binary-TX in both directions) after any file transfer. So although a Telnet
session might be negotiated into binary mode shortly after connection
(e.g., using "telnet -8"), it would be reverted back to NVT mode after any
file transfer.

The request to turn off remote binary-TX after executing external programs
didn't actually accomplish anything since we track the Telnet option states
internally and don't send redundant requests (e.g. the change into a mode
we're already in). External programs aren't expected to send Telnet requests
anyway, so I think this was some holdover from early days of stp/sexyz
development.

Modified Files:


src/sbbs3/main.cpp
diff

Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?

Added Files:


exec/make_areas_ini.js
diff

Modified Files:


src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Add support for new experimental/optional Area File format: areas.ini

As suggested/requested by Fernando Toledo in issue #826, you can:
1. run 'jsexec make_areas_ini.js' to export your areas.bbs file to areas.ini
   (your old areas.bbs is left in place, in tact, unmodified)
2. change your Area File in echocfg->Paths and Filenames->Area File to
   somepath/somefile.ini (e.g. "../data/areas.ini") and SBBSecho will use
   the .ini file format instead of the old AREAS.BBS format (NIH)

You can always go back to your areas.bbs file by just reverting the Area File
setting back to some other non-ini filename (e.g. "../data/areas.bbs").

Incremented version number to v3.23

Of course documentation and echocfg changes will need to follow, but this is
enough to start testing (looking at your Fernando! :-).

I tried to minimize the diff as much as possible and resisted updating
(modernizing, fixing) the very old AREAS.BBS parsing and areafix code.
The new .ini code is largely modeled after the old areas.bbs code, but oh,
xpdev/ini_file makes things so much nicer and easier.

There are no known fixes for any pre-existing area file/fix issues (including
issue #826), but it's always possible I've introduced a new issue.

Modified Files:


exec/init-fidonet.ini
diff

Update AmigaNet and Fido zone 4 details

Use BACKBONE.NA from Vertrauen as echolist for all Fido zones
(anyone have a better authoritative http link to a fixed file
name or archive name?).

Modified Files:


exec/imapservice.js
diff

Add log levels to the rest of the log() calls.

Modified Files:


exec/init-fidonet.ini
diff

Add FidoNet Zone 2 and Zone 4 coordinator names and contact info

Are there official echolists for these zones?

Modified Files:


src/sbbs3/nopen.c
diff

Fix non-Windows build, broken in previous commit

Modified Files:


src/sbbs3/ctrl/AboutBoxFormUnit.cpp
diff

Update cryptlib copyright dates to match latest cryptlib.h

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify fmutex_open() signature even more, add fmutex_init()

Can't used designated initializers in fmutex_init() because this file is still
built with C++Builder6.

Modified Files:


src/sbbs3/nopen.c
diff

We need to initialize the fd to -1 here (since we zero-it out the fmutex_t)

and might return before setting it to anything else.

Modified Files:


src/conio/OverhaulNotes.txt
diff

Add nodes about different screen update methods that will be needed

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Correct initialization of fmutex_t so the file descriptor is -1

For some reason, MSVC was initializing the time_t (second element of the
struct) to -1, not the int fd (the first element), which was initialized to
0. Weird.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Simplify the fmutex_open() usage: always auto-remove when using open/close()

The auto-remove param was only needed for fmutex(), which immediately closes
(and thus don't want auto-removal), so create an internal function that's
used by both fmutex() and fmutex_open().

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Have fmutex_open()/close() accept a fmutex_t* argument

This is needed for *nix where normal (i.e. not Samba-mount) file behavior
requires that we manually unlink() the file, but not until just before closing
it. So we have to keep track of the file name and the 'auto_remove' desire of
the caller. This is not necessary when the file is on a Linux-smbfs, but we
need to work as expected on normal/local *nix file systems too.

This solves atomic lock file removal for *nix, but does not gaurantee lock file
cleanup upon ungraceful process termination (e.g. crash). At least in this
particular case, Windows beats UNIX.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Revert "Use fmutex_open for 100% locking and auto-removal upon
close/termination"

This reverts commit e55183c0953d0b033d9f11796f4290e488596e92.

fmutex_open()'s auto-remove feature doesn't work on normal/local Linux file
systems: unlink() of a file immediately removes its directory entry allowing
subsequent opens of the same file name, defeating the lock.

I had tested fmutex_open() on a Samba mount (from Linux) and it worked as I
wanted (like the Windows version does). Still searching for a good solution:
if a process terminates, gracefully or not, I'd like the file to be removed
at that time and until then, other processes or threads can't create or open
the same lock file (using O_EXCL and file locking to insure this).

Modified Files:


exec/load/openweathermap.js
diff

Update the openweathermap (OWM) API version number

Change requested in issue #747 and from Dan_C in #synchronet

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Create/use function to toggle bit flags (options/settings)

Oh, so much copy/paste eliminated!

Modified Files:


src/syncterm/CHANGES
diff

Log change.

Modified Files:


src/conio/win32gdi.c
diff

When SyncTERM is deactivated and it is in fullscreen mode, minimize.

This appears to be the best we can do when Windows+M (minimize all)
is pressed.  We don't seem to be notified that we should minimize,
only that a different application is being activated.

This also makes Alt-TAB behave a bit more like expected.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

A little beautification of errno logging

Modified Files:


exec/mqtt_spy.js
diff

Add backup Ctrl-C input checking, just incase console.aborted isn't working

Telnet BINARY_TX mode from the client disables CTRL-C input checking in all
versions of SBBS (before now). This change shouldn't be necessary now, but
it worked-around the BINARY_TX issue when I was having it (couldn't abort
mqtt spy).

Modified Files:


src/sbbs3/main.cpp
diff

Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when
connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.

Modified Files:


3rdp/win32.release/cryptlib/bin/cl32.dll
diff

3rdp/win32.release/cryptlib/include/cryptlib.h
diff

Cryptlib v3.4.8 for Win32, patched

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Merge branch 'cryptlib-3.4.8' into 'master'

Update Cryptlib to 3.4.8

See merge request main/sbbs!473

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

3rdp/build/cl-Dynamic-linked-static-lib.patch
diff

3rdp/build/cl-PAM-noprompts.patch
diff

3rdp/build/cl-SSL-fix.patch
diff

3rdp/build/cl-add-patches-info.patch
diff

3rdp/build/cl-add-pubkey-attribute.patch
diff

3rdp/build/cl-add-win64.patch
diff

3rdp/build/cl-algorithms.patch
diff

3rdp/build/cl-allow-duplicate-ext.patch
diff

3rdp/build/cl-allow-none-auth-svr.patch
diff

3rdp/build/cl-allow-none-auth.patch
diff

3rdp/build/cl-allow-pkcs12.patch
diff

3rdp/build/cl-allow-servercheck-pubkeys.patch
diff

3rdp/build/cl-allow-ssh-2.0-go.patch
diff

3rdp/build/cl-allow-ssh-auth-retries.patch
diff

3rdp/build/cl-bigger-maxattribute.patch
diff

3rdp/build/cl-bn-noasm64-fix.patch
diff

3rdp/build/cl-channel-select-both.patch
diff

3rdp/build/cl-clear-GCM-flag.patch
diff

3rdp/build/cl-double-delete-fine-on-close.patch
diff

3rdp/build/cl-endian.patch
diff

3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

3rdp/build/cl-fix-mb-w-conv-warnings.patch
diff

3rdp/build/cl-fix-shell-exec-types.patch
diff

3rdp/build/cl-fix-ssh-channel-close.patch
diff

3rdp/build/cl-good-sockets.patch
diff

3rdp/build/cl-haiku-build.patch
diff

3rdp/build/cl-handle-unsupported-pubkey.patch
diff

3rdp/build/cl-just-use-cc.patch
diff

3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-macosx-minver.patch
diff

3rdp/build/cl-make-channels-work.patch
diff

3rdp/build/cl-mingw-add-m32.patch
diff

3rdp/build/cl-mingw-vcver.patch
diff

3rdp/build/cl-mingw32-static.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

3rdp/build/cl-mingw64-unicode-gibble.patch
diff

3rdp/build/cl-moar-objects.patch
diff

3rdp/build/cl-netbsd-hmac-symbol.patch
diff

3rdp/build/cl-netbsd-no-getfsstat.patch
diff

3rdp/build/cl-no-odbc.patch
diff

3rdp/build/cl-no-pie.patch
diff

3rdp/build/cl-no-safe-stack.patch
diff

3rdp/build/cl-no-testobjs.patch
diff

3rdp/build/cl-no-tpm.patch
diff

3rdp/build/cl-no-via-aes.patch
diff

3rdp/build/cl-noasm-defines.patch
diff

3rdp/build/cl-pass-after-pubkey.patch
diff

3rdp/build/cl-poll-not-select.patch
diff

3rdp/build/cl-posix-me-gently.patch
diff

3rdp/build/cl-prefer-ECC-harder.patch
diff

3rdp/build/cl-prefer-ECC.patch
diff

3rdp/build/cl-quote-cc.patch
diff

3rdp/build/cl-ranlib.patch
diff

3rdp/build/cl-read-timeout-every-time.patch
diff

3rdp/build/cl-remove-march.patch
diff

3rdp/build/cl-server-term-support.patch
diff

3rdp/build/cl-ssh-eof-half-close.patch
diff

3rdp/build/cl-ssh-list-ctr-modes.patch
diff

3rdp/build/cl-ssh-sbbs-id-string.patch
diff

3rdp/build/cl-ssh-service-type-for-channel.patch
diff

3rdp/build/cl-terminal-params.patch
diff

3rdp/build/cl-thats-not-asm.patch
diff

3rdp/build/cl-use-ssh-ctr.patch
diff

3rdp/build/cl-vcxproj.patch
diff

3rdp/build/cl-vt-lt-2005-always-defined.patch
diff

3rdp/build/cl-win32-lean-and-mean.patch
diff

3rdp/build/cl-win32-noasm.patch
diff

3rdp/build/cl-zlib.patch
diff

3rdp/build/cl-zz-country.patch
diff

3rdp/dist/cryptlib.zip
diff

Removed Files:


3rdp/build/cl-fix-ssh-ecc-ephemeral.patch
diff

3rdp/build/cl-fix-ssh-header-read.patch
diff

3rdp/build/cl-fix-test-select.patch
diff

3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-ssl-suite-blocksizes.patch
diff

3rdp/build/cl-win32-build-fix.patch
diff

Update Cryptlib to 3.4.8

Modified Files:


exec/imapservice.js
diff

"support" CHARSET search parameter.

Allow only US-ASCII, and send the BADCHARSET response code indicating
that.  Fixes issue with aerc.

Modified Files:


src/sbbs3/date_str.c
diff

Treat -1 as invalid time in time_as_hhmm()

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Add a "Use Shell" toggle option for fixed events

On *nix, you need the command shell to do wildcard expansion of filenames

Modified Files:


src/sbbs3/userdat.c
diff

Add description comment for find_login_id()

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Use safe_strerror() in place of strerror() - everything multithreaded should

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Resolve MSVC warning

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix the "ERROR x getting data user y" log message (usernum was 0).

Add the errno value to help root-cause.

We really should be using safe_strerror() everywhere.

Modified Files:


exec/load/newsutil.js
diff

Store original "references" header field as an RFC822HEADER in SMB

If an original references header field was supplied with the message, include
*that* in the header (since it should contain all the IDs of the replied-to
message thread) rather than just the message's reply_id (a single message
ID) when sending via NNTP. This maintains more NNTP post integrity when
sending back out via NNTP.

Not sure why we were storing received "references" in the hdr.references
returned by parse_news_header(), we don't seem to be using it anywere. Maybe
copied from 822header.js or mailproc_util.js? Seems like cruft, so remove it.

Also, don't ever send an "In-Reply-To" heder field via NNTP (it's not valid
/used for NNTP articles, per RFC 5536).

Modified Files:


exec/load/newsutil.js
diff

In-Reply-To is not a valid NNTP article header field

... so this was just redundant noise. Altough "References" is a valid header
field *both* for email and nntp articles, "In-Reply-To" is for email only.
per RFC 5536

Modified Files:


exec/load/newsutil.js
diff

Fix the regex in the parsing of the "References" header field

We only want one Message-ID (we'll use the last, since that appears to be the
message being replied to based on SLRN behavior). This fixes reply linkage
when posing from newsreaders that put multiple message-IDs in the
references header field. This is required for SBBSecho to do its magic
creation of the FTN REPLY kludge during export.

This is the fix that Accession was looking for, I think.

Modified Files:


exec/nntpservice.js
diff

Revert "Look up referenced FTN MSGID of messages being POSTed and use in
FTN-REPLY"

This reverts commit d4692e0a5cf643b67928ec8e2cdf9b333c1ab2d0.

Not the fix we're looking for.

Modified Files:


exec/nntpservice.js
diff

Revert "Don't overwrite the posted-reply FTN REPLY ID if it was provided by the
client"

This reverts commit a7f1a24a2ce7e67a87d067a89450a18108b8965d.

Not the fix we're looking for.

Modified Files:


exec/imapservice.js
diff

"Final" optimizations

Use the fastest message base access methods documented.
Cache read/write configs and avoid parsing on read if unchanged.
Make common saves dependent on there being changes.

This is likely as good as it gets (assuming it works)

Modified Files:


exec/imapservice.js
diff

Don't overwrite the offset with the IMAP offset, add a new one.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Use fmutex_open for 100% locking and auto-removal upon close/termination

Modified Files:


exec/nntpservice.js
diff

Don't overwrite the posted-reply FTN REPLY ID if it was provided by the client

Modified Files:


exec/nntpservice.js
diff

Look up referenced FTN MSGID of messages being POSTed and use in FTN-REPLY

... for Acccession

Modified Files:


exec/imapservice.js
diff

Wrap each cleanup step in a separate try/catch in exit func.

Clean up as much as possible.

Modified Files:


exec/imapservice.js
diff

Replace / with - in group/sub names

Almost no clients support a / in names.  Maybe I'll define an x-
extension or something when I write my own mail client.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Leave the user/*.ftp lock file open for better protection

This appears to be the only way to 100% provide mutual exclusivity between
Windows and Linux client sharing a Samba file system.

Also, make fmutex_close() take a pointer to the file descriptor so that we can
better manage the resource (i.e. don't close a descriptor that's already been
closed and possibly valid in another thread).

Modified Files:


exec/newslink.js
diff

Print the correct .ini filename where ptrs are saved

was printing the filename in uppercase if configured as such

Modified Files:


exec/imapservice.js
diff

Overhaul the saved config.

Rather than a single file with config for all subs, use a separate
file for each sub.  This makes clients that do parallel connections
to different mailboxes work much better, and make loading and saving
the config for a mailbox much faster.

The caching stuff is removed to simplify things, and hopefully won't
need to come back... we should just not save config if it doesn't
change.

Only issue I'm still aware of is that 99% of IMAP clients just can't
deal with slashes in mailbox paths.  Like... at all.  The protocol
supports them, but every client seems to have a different way of
breaking with them.

Modified Files:


exec/imapservice.js
diff

Some saved_config cleanup before splitting configs.

Modified Files:


exec/newslink.js
diff

Don't download more msgs than the max for the sub-board (if non-zero)

No sense downloading articles we're just going to toss out the next time
we performance msgbase maintenance.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

We can call remove() right after opening to enable auto-remove on *nix

... which simplifies the fmutex_close() function and signature.

Modified Files:


src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgsrvr.c
diff

Make the spamblock.cfg auto-added entries expirable (configurable duration)

By default, the duration is infinite, but some sysops may not want this
file to be ever-grower but rather periodically pruned by the new trashman
utility.

Sysop that don't use spambait.cfg won't benefit from this change.

Modified Files:


src/sbbs3/main.cpp
diff

Just a little wording update on the fmutex file open log message

Modified Files:


src/sbbs3/nopen.c
diff

Fix for Borland C++ build

Also, don't get hostname unless we're surely going to write to the file.

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_close() method to atomically remove the mutex file on Win32

The 'atomic_remove' argument isn't used in non-Windows builds since we can
remove() before close() on non-Windows OSes already.

Modified Files:


exec/imapservice.js
diff

Add a sanity check on saved config.

I managed to hit a bug where bseen and seen were both completely
filled.  No idea how I hit it, so not positive it's fixed.

This is cheap insurance against the 43k file groung to 1.6MB for
someone else.

Modified Files:


exec/imapservice.js
diff

More speed optimizations

1) Cache the binified seen data rather than regenerate every time
2) Only call js.gc() after a complete fetch or store loop

Modified Files:


src/sbbs3/main.cpp
diff

Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

Modified Files:


src/sbbs3/nopen.c
diff

src/sbbs3/nopen.h
diff

Add fmutex_open() for cases where you want to keep the mutex file open

Modified Files:


src/sbbs3/con_out.cpp
diff

The progress reports (e.g. "[ Done      100.0% ]") should never go to logs

Modified Files:


src/sbbs3/nopen.c
diff

Use sopen(... SH_DENYRW) for fmutex() instead of open()

O_EXCL doesn't appear to be working very reliably over Samba, so let's add
file locking to the equation.

Modified Files:


exec/imapservice.js
diff

Don't rollback scan pointer on sub close.

Modified Files:


exec/imapservice.js
diff

What I hope are the last \Seen and \Recent fixes.

Modified Files:


exec/imapservice.js
diff

Remove set-but-never-used msg_ptrs

Modified Files:


src/sbbs3/main.cpp
diff

Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.

Modified Files:


src/sbbs3/main.cpp
diff

Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was
running last.

Modified Files:


exec/imapservice.js
diff

Simplify close_sub()

Should be no functional change.

Modified Files:


exec/imapservice.js
diff

If open_sub() fails, set readonly to true.

Modified Files:


exec/imapservice.js
diff

Save scan_ptr for all subs in config.

Also, make save_cfg() require that the lock be held.

Modified Files:


exec/imapservice.js
diff

More Seen flag overhaul.

This should now actually work properly.
Also, add a debug_exceptions flag to rethrow exceptions so I can
get line numbers.

Modified Files:


exec/imapservice.js
diff

Roll the epoch back to zero if it hits 9007199254740991

It shouldn't though.

Modified Files:


exec/imapservice.js
diff

Fix BODYSTRUCTURE bug that prevented macOS Sequoia from loading messages

Also, always use full_send(), not the socket send.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Remove "QWK Prepack" feature (has been on chopping block for a long time)

This removes unnecessary some cruft and complexity, most especially from the
event_thread().

Using sbbs_t::fremove() instead of remove(). This probably resolves some
Coverity issues where we weren't checking the return value.

Modified Files:


src/sbbs3/sbbs.h
diff

sbbs_t::fremove() will now, by default, ignore (not log) ENOENT errors

ENOENT = "No such file or directory"

Passing 'true' for the optional 'log_all_errors' parameter overrides this
(logs all errors, including ENOENT).

Modified Files:


exec/testbuild.js
diff

Updates nightly builds in filebase

Modified Files:


exec/newslink.js
diff

Return 1 on failure (e.g. authentication failure), not 0

Only log message header read error if the msgbase.status is non-zero

Don't try to import anything if the stop semfile is signaled while
exporting.

Increment revision to 1.2